Bug #460

Feature #117: Support multiple model configs with separate channelconfigs

Feature #285: Individual FrSky Alarms for a model

Task #183: Send FrSky alarms for the model upon model selection

App does not request alarms from module when switching models

Added by Espen Solbu over 5 years ago. Updated over 5 years ago.

Status:ClosedStart date:06/08/2012
Priority:NormalDue date:
Assignee:Espen Solbu% Done:

100%

Category:-Spent time:-
Target version:2.0 Multiple models

Description

Use case
  • When not automatically sending models alarms to FrSky module when switching model
  • Using Model 1, changing to Model 2, should request alarms from module to trigger alarm comparison

Subtasks

Task #467: Add base activity that can contain all dialogs and menus ...Closed

Task #468: Make server send broadcast whenever model gets changedClosed

Task #469: Modify ActivityBase to react to ModelChange broadcast and...Closed

Associated revisions

Revision 430
Added by Espen Solbu over 5 years ago

refs #460 started work on a baseclass activity that all activities can extend

Revision 442
Added by Espen Solbu over 5 years ago

closes #460 Turns out that i can't have onCreateDialog in both the base class and the subclass. It seems to work, the code in the create part of the base class runs, however the dialog does not show. I have moved all dialog code to the base class now. I don't like this solution, we should investigate using DialogFragment and FragmentManager instead

History

#1 Updated by Espen Solbu over 5 years ago

It is now requesting alarms, however the AlertDialog is not launched from this activity, so incoming alarms are not evaluated

#2 Updated by Espen Solbu over 5 years ago

Probably best way to do this is to add a "base activity class" that the other activities can extend. this way the dialog (and possibly the menu code) can be hosted by the base activity instead of the individual activities

#3 Updated by Espen Solbu over 5 years ago

  • Parent task set to #183

#4 Updated by Espen Solbu over 5 years ago

  • Status changed from New to Closed
  • % Done changed from 50 to 100

Applied in changeset r436.

#5 Updated by Espen Solbu over 5 years ago

  • Status changed from Closed to In Progress

I somehow broke this again. onCreateDialog is called for DIALOG_ALARMS_MISMATCH, but dialog is not shown. Should probably add Bundle similar to delete dialogs

#6 Updated by Espen Solbu over 5 years ago

  • Status changed from In Progress to Closed

Applied in changeset r442.

Also available in: Atom PDF