Bug #411

Source channel list contain too many channels

Added by Espen Solbu over 5 years ago. Updated over 5 years ago.

Status:ClosedStart date:04/26/2012
Priority:NormalDue date:
Assignee:Hans Cappelle% Done:

100%

Category:-Spent time:-
Target version:2.0 Multiple models

Description

There is a bug in r355

for(Channel ch : FrSkyHub.getInstance().getSourceChannels().values())
was changed to
for(Channel ch : FrSkyServer.getSourceChannels().values())

This means that the server source channels are added to the list (again), instead of the hub source channels.

I am assigning this to you, as there might be some reason why the original line should not be there anymore. Though the hub (not the server) should hold the hub channels. I tested commenting it back, and i can again get hub values into channels

Associated revisions

Revision 369
Added by Espen Solbu over 5 years ago

refs #411 changed back to adding the hub channels instead of the server channels

Revision 373
Added by Hans Cappelle over 5 years ago

closes #411 mistake in refactoring

Revision 374
Added by Hans Cappelle over 5 years ago

refs #411 removed static from method since it relies on data initialised in ctor

History

#1 Updated by Hans Cappelle over 5 years ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

Applied in changeset r373.

#2 Updated by Hans Cappelle over 5 years ago

My mistake. I refactored the non static call of the static getSourceChannels() method but referenced FrSkyServer instead.

#3 Updated by Hans Cappelle over 5 years ago

not sure how I can reopen a ticket but this one should. The static methods rely on data initialised in the ctor = no good.

Also available in: Atom PDF