Bug #357

Task #351: Performance refactoring

Task #355: Load models into server memory

Add channel, adds two channels

Added by Espen Solbu over 5 years ago. Updated over 5 years ago.

Status:ClosedStart date:02/13/2012
Priority:NormalDue date:
Assignee:Espen Solbu% Done:

100%

Category:-Spent time:-
Target version:2.0 Multiple models

Description

Note, two channels is added to the modelMap, but only one of them is stored in the database

Associated revisions

Revision 299
Added by Hans Cappelle over 5 years ago

refs #357 toString added for debugging

Revision 301
Added by Espen Solbu over 5 years ago

closes #357 Removed the duplicate addChannel, also changed Channel.toString back as this is used in the Spinners

History

#1 Updated by Hans Cappelle over 5 years ago

Espen

I debugged this but didn't fix it since I'm not sure what the desired behavior is. I added some toString() methods though. What happens is that FrSkyServer.addChannel() is called twice.

First Call
from: ActivityChannelConfig.applyChannel() line: 326
Where the channelId is still -1 so a db insert is done and the channel is added to the map you refer to.

Second Call:
from: ActivityModelConfig.onActivityResult(int, int, Intent) line: 342
Where the channelId now is known so no more db insert but still added to the map (second time).

#2 Updated by Espen Solbu over 5 years ago

thanks, I try to get it fixed today. I think probably just remove the second call, as there is no longer a need to update the channellist for the model (used to be when it was in the database) Just need to verify proper behaviour when editing "new channel" vs "existing channel"

#3 Updated by Espen Solbu over 5 years ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

Applied in changeset r301.

Also available in: Atom PDF