Task #212

Refactor Channel settings

Added by Espen Solbu almost 6 years ago. Updated almost 6 years ago.

Status:ClosedStart date:12/08/2011
Priority:NormalDue date:
Assignee:Espen Solbu% Done:

100%

Category:RefactorSpent time:-
Target version:2.0 Multiple models

Description

Should have setters and getters, writing from and to settings storage.

Also run "Get from settings" upon creation..


Subtasks

Task #231: Have Channel implement ParcelableClosedEspen Solbu

Bug #237: _silent is not stored in databaseClosedEspen Solbu

Task #245: Remove old settings storageClosedEspen Solbu

Task #246: Redo server's source channelsClosedEspen Solbu

Task #247: Remove name property from ChannelClosedEspen Solbu

Task #251: Cleanup propertiesClosedEspen Solbu

Associated revisions

Revision 178
Added by Espen Solbu almost 6 years ago

refs #228,#212 Almost done

Revision 206
Added by Espen Solbu almost 6 years ago

closes #212, #247 Removed name property on Channel, removed references to sharedSettings in channels

History

#1 Updated by Espen Solbu almost 6 years ago

  • Target version changed from 1.2 to 2.0 Multiple models

#2 Updated by Espen Solbu almost 6 years ago

Broadcast approach:
Listen to all channel updates?
Listen to my source channel updates?

Mine;
In channel
Need:
listenTo(int id)
-> Register listener for "biz.onomato.frskydash.update.channel."+id

onReceive
inValue = intent.getFloatExtra("channelValue");

onUpdate..
New intent
action="biz.onomato.frskydash.update.channel."+id
putFloatExtra("channelValue")

Needs understanding of "id"

PRO: Would listen to only relevant source channels
Very little involved in picking up the value from a channel
More loosely coupled than dedicated listeners

CON: Many broadcasts vs dedicated listeners
Broadcast count will increase by number of channels

Challenges:
Maintain channel id
Channel aware of listeners? not broadcast if no listeners?

#3 Updated by Espen Solbu almost 6 years ago

  • Status changed from New to Closed
  • % Done changed from 83 to 100

Applied in changeset r206.

Also available in: Atom PDF